Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Lint and format #166

Merged
merged 8 commits into from
Oct 24, 2020
Merged

Lint and format #166

merged 8 commits into from
Oct 24, 2020

Conversation

rbrcsk
Copy link
Collaborator

@rbrcsk rbrcsk commented Oct 23, 2020

No description provided.

Looks like the name confusion (there were two functions with this name) caused this, the first one to be overriden and not run at all, hence the error could't surface. Luckily this is only a test error, and not a code error.
@codecov-io
Copy link

Codecov Report

Merging #166 into master will decrease coverage by 0.03%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   95.78%   95.75%   -0.04%     
==========================================
  Files           9        9              
  Lines         403      400       -3     
  Branches       53       52       -1     
==========================================
- Hits          386      383       -3     
  Misses         16       16              
  Partials        1        1              
Impacted Files Coverage Δ
pushbullet/channel.py 100.00% <ø> (ø)
pushbullet/errors.py 100.00% <ø> (ø)
pushbullet/listener.py 66.66% <66.66%> (-0.73%) ⬇️
pushbullet/_compat.py 100.00% <100.00%> (ø)
pushbullet/chat.py 100.00% <100.00%> (ø)
pushbullet/device.py 100.00% <100.00%> (ø)
pushbullet/filetype.py 88.23% <100.00%> (ø)
pushbullet/pushbullet.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6f9c5...1d409d9. Read the comment docs.

@rbrcsk
Copy link
Collaborator Author

rbrcsk commented Oct 24, 2020

I think codecov is a bit too overeager. There were no code changes, only formatting, but that increased the number of lines in Listener.py - hence the coveraged decreased.

@rbrcsk rbrcsk merged commit 5fdd79f into master Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants