Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlap between Key and Wallet #45

Closed
ssadler opened this issue Jun 29, 2014 · 2 comments
Closed

Overlap between Key and Wallet #45

ssadler opened this issue Jun 29, 2014 · 2 comments

Comments

@ssadler
Copy link

ssadler commented Jun 29, 2014

I havn't looked deeply into the differences but it seems that both Key and Wallet do largely the same thing, ie, allow to instantiate with a public or private key and traverse. Which are we supposed to use?

While I'm at it:

  • It'd be nice if Key.subkey accepted integers
  • I think there's a mistake in the README; shouldn't "where P is a subkey of P" be "where P is a subkey of K" ?
  • Another: "pycoin.bip32.Wallet" should be "pycoin.bip32.key.Wallet"

Cheers

@richardkiss
Copy link
Owner

Use "Key".

My plan is to move some duplicate functionality out of the BIP32 wallet, then create a class the supports the Electrum deterministic wallet. Then "Key" will support both BIP32 and Electrum.

Sorry for the confusion.

@ssadler
Copy link
Author

ssadler commented Jun 30, 2014

Thanks

@ssadler ssadler closed this as completed Jun 30, 2014
richardkiss added a commit that referenced this issue Jun 30, 2014
ghtdak pushed a commit to ghtdak/pycoin that referenced this issue Jul 16, 2016
[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:50:53 2016]
[from commit: bf44a65]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants