Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #61 : save code in localstorage #63

Merged
merged 1 commit into from
Sep 8, 2015
Merged

Fixes #61 : save code in localstorage #63

merged 1 commit into from
Sep 8, 2015

Conversation

jmtavares
Copy link
Contributor

No description provided.

@richgilbank
Copy link
Owner

Sorry, missed this somehow. Should be able to take a look tonight 👍

@richgilbank
Copy link
Owner

@yconoclast Is this currently working for you in stable? Code LGTM, but it looks like the input isn't being persisted. I'd guess it's from chrome.storage.sync not working (which is why I went with localStorage for other things). If it is working for you, which version?

@richgilbank
Copy link
Owner

Scratch that, seems to be working as expected after a chrome restart. Thanks!

richgilbank pushed a commit that referenced this pull request Sep 8, 2015
Fixes #61 : save code in localstorage
@richgilbank richgilbank merged commit adbd3bb into richgilbank:master Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants