-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add various type hints #119
base: main
Are you sure you want to change the base?
Conversation
Can you fix the tests? I think you just have to add Run the tests locally, you can find which file is the problem exactly: https://github.com/richibrics/IoTuring/blob/main/docs/DEVELOPMENT.md#tests Run it in docker so you can use the same python version. |
That's what I get for doing this quickly on my train ride. I need to stop
using
`git add .`
Sorry for that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Other things to do:
- There is also a predefined choice list in
Terminal
entity, please upgrade that toTypedDict
as well - I just searched for Callback and I still found some methods in some entities where MQTTMessage could be hinted
Co-authored-by: infeeeee <gyetpet@mailbox.org>
Some of them may be debated upon. Most of the changes are return hints