Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when scrolling to end of file (on Mac) #1

Closed
richrd opened this issue Jan 26, 2015 · 2 comments
Closed

Crashes when scrolling to end of file (on Mac) #1

richrd opened this issue Jan 26, 2015 · 2 comments
Assignees
@richrd
Labels
bug
Milestone
Version 1.0.0

Comments

@richrd
Copy link
Owner

richrd commented Jan 26, 2015

Gives error on line 225 in self.window.addstr(...
Occurs on Mac.
@richrd richrd added the bug label Jan 26, 2015
@richrd richrd self-assigned this Jan 26, 2015
@richrd richrd changed the title Crashes when scrolling to end of file Crashes when scrolling to end of file (on Mac) Jan 26, 2015
@richrd
Copy link
Owner Author

richrd commented Mar 16, 2015

Apparently a crash can also happen on Unix when zooming (resizing) the terminal.

Error below:
self.editor().move_win( (y_start, 0) )
File "[path]/viewer.py", line 252, in move_win
self.window.mvwin( yx[0], yx[1] )
_curses.error: mvwin() returned ERR

Update:
Normal zooming doesn't seem to be a problem, but agressively fast zoom-in seems to make the shit hit the fan. I guess that some rendering code is run before Suplemon knows the new size of the terminal. Should optimize rendering anyway!

@richrd richrd added this to the Version 1.0.0 milestone Apr 10, 2015
@richrd
Copy link
Owner Author

richrd commented May 3, 2015

This seems to be resolved by the rendering optimizations done earlier. Closing for now.

@richrd richrd closed this as completed May 3, 2015
richrd pushed a commit that referenced this issue Sep 28, 2015
@severin31
Merge pull request #1 from severin31/misprint-1
23cf52e 
Update README.md (misprint)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richrd richrd

Labels
bug
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
1 participant
@richrd