make isHolCache access thread-safe #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am proposing to introduce a locking mechanism with
RWMutex
which helps to optimize read path by allowing multiple reads at once. Perform map initialization usingsync.Once
.sync.Map
does not have an api for measuring the length of it. Greatly complicates things for eviction implementation. Of course we could usesync/atomic
and an int as an external counter but in this case I don't believe this additional complexity is worth it. Theoretically,sync.Map
might be a better optionMy assumptions might be incorrect, feedback is welcome. Would gladly refactor this to use
sync.Map
if you see the benefit.solves #128