Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Bugsnag 6.26.2 and above #18

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Support Bugsnag 6.26.2 and above #18

merged 1 commit into from
Aug 25, 2023

Conversation

rickclephas
Copy link
Owner

No description provided.

@rickclephas rickclephas merged commit 9784726 into master Aug 25, 2023
@rickclephas rickclephas deleted the bugsnag-6.26.2 branch August 25, 2023 21:47
@kpgalligan
Copy link

Huh. Did bugsnag break something?

@rickclephas
Copy link
Owner Author

rickclephas commented Aug 25, 2023 •
edited

Yeah they no longer use unhandled to determine if the exception should be saved to disk instead of being send immediately. Based on my tests all exceptions are lost with Bugsnag 2.26.2 or above, due to the immediate termination of the app. Had to "override" the new originalUnhandledValue property to workaround their updated check 😅.

@rickclephas
Copy link
Owner Author

Specifically the following change broke our unhandled exception recording: bugsnag/bugsnag-cocoa#1549

@rickclephas
Copy link
Owner Author

FYI opened a feature request for an officially support API: bugsnag/bugsnag-cocoa#1575.

@kpgalligan kpgalligan mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rickclephas @kpgalligan