Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking issue in Resampler.stream #110

Conversation

lox
Copy link
Contributor

@lox lox commented Jun 2, 2024

Description of changes

Follow-on to #108.

In the process of trying to keep Resampler.process intact (as it's used by the web package), I missed a spot where the implementation for Resampler.stream blocked on building an input buffer which doesn't show up in the tests, but it does in manual testing with very long files.

This fixes the issue.

Checklist

  • Added a test to verify that changes work as expected (if one doesn't exist already)
  • Ran automated tests successfully
  • Viewed manual test site and verified that pages are working
  • Bumped versions in relevant packages
  • Updated relevant changelogs
  • Ran npm run format

@ricky0123 ricky0123 merged commit 2020b79 into ricky0123:master Oct 20, 2024
@ricky0123
Copy link
Owner

Thanks a lot @lox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants