Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing issues in v2.5.0 #151

Closed
rickyah opened this issue Jul 19, 2017 · 5 comments
Closed

Signing issues in v2.5.0 #151

rickyah opened this issue Jul 19, 2017 · 5 comments
Assignees
@rickyah
Labels
bug

Comments

@rickyah
Copy link
Owner

rickyah commented Jul 19, 2017

ini-parser 2.5.0 seems to have some signage issues. Strong-name verification fails on my end, with this exception. I don't think the problem is on my end since 2.4.0 works just fine.

"Could not load file or assembly 'INIFileParser' or one of its dependencies. Strong name signature could not be verified. The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)"
@yuuhhe
Copy link

yuuhhe commented Jul 21, 2017

crash on web application only

@rickyah
Copy link
Owner Author

rickyah commented Jul 23, 2017 •
edited
Loading

A new nuget version 2.5.2 with strongname signing is available
https://www.nuget.org/packages/ini-parser/2.5.2

@flmontpetit
Copy link

Thanks a lot for this

@rickyah
Copy link
Owner Author

rickyah commented Jul 24, 2017 •
edited
Loading

Thank you for letting me know!

Seems like a bug in VS, or a problem when I migrated from xamarin studio to the new "version" visual studio mac. The project is actually configured to sign the library's dll, but it does not work. It just skips it. So I had no idea I pushed the library without a strong name (signed)

Fortunately the feedback was quick! ;)

@rickyah rickyah self-assigned this Jul 24, 2017
@rickyah rickyah added the bug label Jul 24, 2017
@yuuhhe
Copy link

yuuhhe commented Jul 25, 2017

well done

rickyah added a commit that referenced this issue Apr 7, 2018
@rickyah
Solves dll not being strong named
446963f 
Fixes #151

For some reason Visual Studio Mac, nor the command line, strong sign
FileIniParser.dll as part of the build process, so the signing is now being
done as part of the nuget-package generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickyah rickyah

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickyah @yuuhhe @flmontpetit