Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested navigation inside a Modal does not work #29

Closed
therealjohn opened this issue Jan 9, 2016 · 5 comments
Closed

Nested navigation inside a Modal does not work #29

therealjohn opened this issue Jan 9, 2016 · 5 comments

Comments

@therealjohn
Copy link

CoreMethods.PushPageModel<T> does not navigate as expected in a Modal page.

Here is a video of the behavior: http://screencast.com/t/gErUL9c2h

The basic navigation wraps any new Modal in a NavigationPage, which is great. However, when trying to navigate to pages while that Modal is displayed, the pages are pushed underneath (in the other parent NavigationPage).

I have been playing with this and investigating my options. Suggestions are welcome.

@jfversluis
Copy link

That is why there is a modal parameter that you can set to try while calling this method?

Op 9 jan. 2016 om 21:35 heeft John Miller notifications@github.com het volgende geschreven:

CoreMethods.PushPageModel does not navigate as expected in a Modal page.

Here is a video of the behavior: http://screencast.com/t/6DUPjV8DmfAg

The basic navigation wraps any new Modal in a NavigationPage, which is great. However, when trying to navigate to pages while that Modal is displayed, the pages are pushed underneath (in the other parent NavigationPage).

I have been playing with this and investigating my options. Suggestions are welcome.


Reply to this email directly or view it on GitHub.

@therealjohn
Copy link
Author

@jfversluis

I might be confused. Using the modal paramater is just a toggle to cause a Modal to be used, not to tell that you are navigating inside a modal. If you were to just pass a true, it would display another modal on top of this one. Instead, I want to be able to navigate forward inside the NavigationPage stack that is already wrapping this Modal.

See this.

@rid00z
Copy link
Owner

rid00z commented Jan 9, 2016

I have a solution for this that I'm working on now and will have done in
next days.

The solution is based on having multiple Navigation services.

On Sunday, 10 January 2016, John Miller notifications@github.com wrote:

@jfversluis https://github.com/jfversluis

I might be confused. Using the modal paramater is just a toggle to cause a
Modal to be used, not to tell that you are navigating inside a modal. If
you were to just pass a true, it would display another modal on top of this
one. Instead, I want to be able to navigate forward inside the
NavigationPage stack that is already wrapping this Modal.

See this
https://github.com/rid00z/FreshMvvm/blob/master/src/FreshMvvm/FreshNavigationContainer.cs#L16-L26
.


Reply to this email directly or view it on GitHub
#29 (comment).

Michael Ridland | Technical Director | Xamarin MVP

XAM Consulting - Mobile Technology Specialists

www.xam-consulting.com

Blog: www.michaelridland.com

@therealjohn
Copy link
Author

@rid00z That is great to hear. Thanks for your effort on this, loving it!

@rid00z
Copy link
Owner

rid00z commented Jan 14, 2016

This is solved in the current code base and will be in next release.

@rid00z rid00z closed this as completed Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants