Minor riemann-hwmon improvements
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some old hardware do not report CPU package temperature and the creation of `temp1_*` (reserved for package temperature) files for the CPU is skipped. When this happen, other `temp2_*`, `temp3_*` etc. files are available as usual for each core temperature. Because we tried to enumerate the possible device names, we failed to catpure these sensor values. Moreover, people report on the internet "holes" in the numbering of the hwmon files, skipping from 8 to 10. In order to avoid these issues, rely on globbing to find all appropriate files rather than on enumerations.
Some sensors do not have a label. In this case, we do not want to have a trailing space in the service name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riemann-hwmonreliability