Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor riemann-hwmon improvements #298

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Minor riemann-hwmon improvements #298

merged 2 commits into from
Jun 29, 2024

Commits on Jun 29, 2024

  1. Improve riemann-hwmon reliability 

    Some old hardware do not report CPU package temperature and the creation
of `temp1_*` (reserved for package temperature) files for the CPU is
skipped.  When this happen, other `temp2_*`, `temp3_*` etc. files are
available as usual for each core temperature.

Because we tried to enumerate the possible device names, we failed to
catpure these sensor values.

Moreover, people report on the internet "holes" in the numbering of the
hwmon files, skipping from 8 to 10.

In order to avoid these issues, rely on globbing to find all appropriate
files rather than on enumerations.
    @smortex
    smortex committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    88edb6a View commit details
    Browse the repository at this point in the history

  2. Avoid trailing space when sensor has no label 

    Some sensors do not have a label.  In this case, we do not want to have
a trailing space in the service name.
    @smortex
    smortex committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    fbd0775 View commit details
    Browse the repository at this point in the history