Emergency timeout for failed HCI sends #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estutzenberger
approved these changes
Mar 18, 2019
| s.rmu.Lock() | ||
| n, err := unix.Read(s.fd, p) | ||
| s.rmu.Unlock() | ||
| // Close always sends a dummy command to wake up Read |
There was a problem hiding this comment.
This comment is a little unclear. Maybe Read needs to be removed?
There was a problem hiding this comment.
would changing "wake up Read" to "wake this function up" help?
There was a problem hiding this comment.
I guess? Do I understand this?
When the socket is closed, a dummy command is always sent to wake up the socket read function.
|
I'm confident these changes fix known problems, and pretty sure they won't cause other damage. I'm a bit worried there might still be other concurrency problems in both the command state machine and the socket close logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen a stack trace where go-ble locked up because ble/linux/hci.(*HCI).send waits forever on a select for data to return.
This probably indicates some kind of problem deeper in the Bluetooth stack, but it would be good if the library didn't hang in these situations.
Now includes some additional cleanup to the socket Read path to handle some weird lockups on send and device stop, which were revealed in testing for the send failure.