Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing condition on file age in DeleteOldFiles #701

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Fixed missing condition on file age in DeleteOldFiles #701

merged 1 commit into from
Jun 28, 2019

Conversation

ppech
Copy link
Contributor

@ppech ppech commented Jun 5, 2019

I found out, that in FileSystemUploadedFileStorage in DeleteOldFiles method is missing condition on maxCreatedDate. So I copied method code from FileSystemReturnedFileStorage.

@dnfclas
Copy link

dnfclas commented Jun 5, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

exyi
exyi approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@exyi exyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thank you for fixing that.

@quigamdev quigamdev merged commit 403579e into riganti:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exyi exyi exyi approved these changes

@quigamdev quigamdev quigamdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppech @dnfclas @exyi @quigamdev