Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major updates #32

Merged
merged 42 commits into from
Mar 18, 2018
Merged

Major updates #32

merged 42 commits into from
Mar 18, 2018

Conversation

fsimkovic
Copy link
Contributor

Added

  • conkit.plot subpackage refactored to allow matplotlib access of Figure instances. This provides
    functionality similar to seaborn, so matplotlib.Axes can be provided into which a plot is drawn.
  • ContactMap.as_list function to represent the contact map as a 2D-list of residue indexes
  • conkit.misc.normalize function to apply Feature scaling normalization
  • CONTRIB.rst file to list all contributors
  • SequenceFile.diversity property defined by :math:\sqrt{N}/L
  • ContactMap.reindex to reindex a contact map given a new starting index
  • ContactMap.singletons returns a copy of the contact map with singleton contacts, i.e. ones without neighbors

Changed

  • Changed API interface for conkit.plot in accordance to necessary changes for above
  • ContactMapFigure now accepts lim parameters for axes limits
  • ContactMapFigure and ContacctMapChordFigure improved to better space marker size
  • Typos corrected in documentation

Felix Simkovic added 30 commits January 8, 2018 11:42
…e instances. This provides functionality similar to seaborn, so matplotlib.Axes can be provided into which a plot is drawn.
@fsimkovic fsimkovic requested a review from hlasimpk March 14, 2018 16:44
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 81.259% when pulling ccf669e on fsimkovic:master into 7ae7464 on rigdenlab:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 81.259% when pulling ccf669e on fsimkovic:master into 7ae7464 on rigdenlab:master.

@coveralls
Copy link

coveralls commented Mar 14, 2018

Coverage Status

Coverage decreased (-0.02%) to 81.658% when pulling e11d165 on fsimkovic:master into 7ae7464 on rigdenlab:master.

@hlasimpk
Copy link
Contributor

Note to self: I'm up to e0c3616

no obvious problems so far!

"""The diversity of an alignment defined by :math:`\sqrt{N}/L`.

``N`` equals the number of sequences in
thethe alignment and ``L`` the sequence length
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 'thethe'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be added in a later PR.

Copy link
Contributor

@hlasimpk hlasimpk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a typo in a doc string I can't see any obvious errors (or at least none that weren't corrected by subsequent commits)

@fsimkovic fsimkovic merged commit 618cfa6 into rigdenlab:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants