Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update Qiskit version & populate coupling map #26

Closed
wants to merge 1 commit into from

Conversation

j4ustin
Copy link
Contributor

@j4ustin j4ustin commented Feb 11, 2022

@pranavm1502
Copy link

Looking forward to this PR being merged! Updating will also allow use of QASM3 which can potentially be used to resolve #36

@dbanty
Copy link
Contributor

dbanty commented May 26, 2022

Hey y'all, sorry for letting this languish. I think these changes had been pulled into the rc branch and are now in main, but could you double-check before we cut a new release?

@pranavm1502
Copy link

Given that the Aspen devices have non-contiguous qubit indexing, just adding the coupling_map is not sufficient to us Qiskit transpilers. For example, the following code-snippet throws an error -

from qiskit.transpiler import CouplingMap

graph = qc.quantum_processor.qubit_topology()
h = graph.to_directed()
cm = h.edges()
qc_couplingmap = CouplingMap(cm)
qiskit.transpile(bv_circs[3], coupling_map=qc_connectedmap)

CouplingError: 'coupling graph not connected'

I think the correct way to avoid this problem is to use the faulty_qubit for proper interfacing with Qiskit

See def _create_faulty_qubits_map(backend): at https://qiskit.org/documentation/_modules/qiskit/compiler/transpiler.html#transpile

@dbanty
Copy link
Contributor

dbanty commented Jun 2, 2022

@pranavm1502 to be clear, this is something that must be added additionally, but not something which this PR contains that main does not?

For this particular PR, I just want to make sure that everything here has already been incorporated into main before I close this and release that.

@strangeworks strangeworks closed this by deleting the head repository Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants