Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(quil-py): Publish documentation on GitHub Pages #314

Merged
merged 39 commits into from
Dec 12, 2023

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Nov 22, 2023

Use pdoc and GitHub pages to build and deploy a live site with our quil-py type hints as documentation.

Due to some issue between pdoc, pyo3, and type hints, nested submodules don't render. This may be related to this issue.

@MarquessV
Copy link
Contributor Author

GH pages doesn't yet support previewing documentation from a PR, so I had to test the workflow by deploying from this branch. That means the docs are live!

As a todo, I'll need to remove this branch from the allowlist for GH pages deployments, and refactor the workflow so that it only triggers on a full release.

Copy link

github-actions bot commented Dec 1, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-12 17:33 UTC

@MarquessV MarquessV marked this pull request as ready for review December 1, 2023 18:29
@MarquessV
Copy link
Contributor Author

This PR now uses a GitHub action to deploy a preview of the new documentation. On push to main, it will update the main GitHub pages site.

Copy link
Contributor

@Shadow53 Shadow53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some stuff was committed by accident, but otherwise looks good.

quil-py/2 Outdated Show resolved Hide resolved
quil-py/build/docs/quil.html Outdated Show resolved Hide resolved
quil-py/docs/expression.html Outdated Show resolved Hide resolved
quil-py/quil/.null-ls_220677___init__.py Outdated Show resolved Hide resolved
@MarquessV MarquessV merged commit 655ff3f into main Dec 12, 2023
14 checks passed
@MarquessV MarquessV deleted the publish-quil-py-docs branch December 12, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants