Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): remove github-pages, update all deps and Ruby #191

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

m4tx
Copy link
Member

@m4tx m4tx commented Jan 5, 2024

A nice win is removing some unused dependencies pulled in by the github-pages gem.

Not-so-nice thing is that along with the Sass upgrade, we've earned a lot of deprecation warnings caused by the theme we're using — see mmistakes/minimal-mistakes#4054. Whether or not the theme will ever get updated is an open question — its last release was in July 2021.

@m4tx m4tx requested review from seqre and Iipin January 5, 2024 19:42
Copy link
Contributor

@seqre seqre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we need to have the newest & greatest if we're not even going to use it? It's a simple static website after all, we could just pin deps at the latest supported and probably be fine.

@m4tx
Copy link
Member Author

m4tx commented Jan 5, 2024

@seqre I can't say you're not right, but I'm just uncomfortable being stuck with an old version of Jekyll and no way to upgrade the Ruby version while having dependabot opening PRs like mad to upgrade it. Reducing technical debt, or something.

@m4tx m4tx merged commit 53ade10 into master Jan 5, 2024
1 check passed
@m4tx m4tx deleted the update-deps branch January 5, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants