Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

percent_decompiled: Add split percentages #88

Merged
merged 5 commits into from
Jul 30, 2021
Merged

percent_decompiled: Add split percentages #88

merged 5 commits into from
Jul 30, 2021

Conversation

riptl
Copy link
Collaborator

@riptl riptl commented Jul 30, 2021

Adds a new "code (split)" column to percent_decompiled.

The new output looks like this:

--------------------------------------------------
    part     code split  code decomp  data decomp 
 DOL            10.496%       9.272%       1.724%
 > DOL/NW4R      0.618%       0.618%
 > DOL/RFL       0.000%       0.000%
 > DOL/DWC       0.217%       0.217%
 > DOL/SPY      81.851%      81.851%
 > DOL/RVL       5.773%       2.779%
 > DOL/EGG       4.713%       4.713%
 REL             0.016%       0.016%       0.009%
 TOTAL           4.120%       3.641%       1.367%
--------------------------------------------------
Player:
 - 5463 BR (main.dol)
 - 5000 VR (StaticR.rel)
1 BR = 118.0 lines of asm code.
1 VR = 183.3 lines of asm code.

Also now rendering table to HTML.
To facilitate this, the graphic.py CI job was moved into the Linux/Wine build.

grafik

@riptl riptl added the devops Changes to the build system and CI label Jul 30, 2021
@riidefi
Copy link
Owner

riidefi commented Jul 30, 2021

Can we add borders to the HTML table? LGTM otherwise

@riptl
Copy link
Collaborator Author

riptl commented Jul 30, 2021

Yes, will do

@riidefi riidefi merged commit 21a6190 into riidefi:master Jul 30, 2021
@riidefi riidefi mentioned this pull request Jul 30, 2021
@riptl riptl deleted the split-percent branch July 31, 2021 06:05
riidefi pushed a commit that referenced this pull request Feb 25, 2024
* percent_decompiled: Add split percentages

* percent_decompiled: remove 'data split' column

* add HTML table

* CI: Merge build and pages jobs

* Fix build.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Changes to the build system and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants