Fix long argument handling in construct_exec_list #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
construct_exec_list would construct long arguments such as the directory argument into "--directory DIRECTORY" instead of "--directory=DIRECTORY", so add the missing "=". Also explicitly exclude the known cases that should not be generated (mostly ones that represent arguments that were not given), and put an assert in the fallthrough else statement to catch any future new cases.
rikardg
force-pushed
the
construct_exec_list_long_arguments
branch
from
4201fd2
to
292a4f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
construct_exec_list would construct long arguments such as the directory argument into "--directory DIRECTORY" instead of "--directory=DIRECTORY", so add the missing "=".
Also explicitly exclude the known cases that should not be generated (mostly ones that represent arguments that were not given), and put an assert in the fallthrough else statement to catch any future new cases.