Only try to partition Byggfile.yml actions if there are any #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the transform action from examples/trivial would fail with a "Could not find action" error, but building the same action as the default action would work. This was due to the partitioning code trying to partition the empty list of actions from Byggfile.yml when there was an action given on the command line, and this would fail. The default action case would succeed because examples/trivial/Byggfile.yml has a default action declared. Fix this in the partitioning code so that Byggfile.py will be evaluated. Also add a test case to noxfile.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the transform action from examples/trivial would fail with a "Could not find action" error, but building the same action as the default action would work.
This was due to the partitioning code trying to partition the empty list of actions from Byggfile.yml when there was an action given on the command line, and this would fail.
The default action case would succeed because
examples/trivial/Byggfile.yml has a default action declared.
Fix this in the partitioning code so that Byggfile.py will be evaluated.
Also add a test case to noxfile.py.