feature: add support for HTTP DELETE to Connection class and WithConn… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TimCummings I didn't use the delete method, that's why it wasn't added. Just out of curiosity, are you using master or 0.1.x branch? |
|
I'm using master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ection module
This adds
Connection.deletesimilar to existingget,post, andputmethods. I haven't added anything toBaseRecordto actually invokedelete. I figure as destructive is it could be, it could be up to users to implement their own access in their record class(es). But I'd be happy to add something toBaseRecordif you'd like.Also, I opened this pull request from a branch matching your current master branch so you could review both of my open PRs in isolation. If it would be more helpful to merge them then submit a PR, I'm happy to do that. Thanks for this handy project!