Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAws errors are not caught #23

Closed
shadowhand opened this issue Sep 26, 2022 · 0 comments · Fixed by #24
Closed

AsyncAws errors are not caught #23

shadowhand opened this issue Sep 26, 2022 · 0 comments · Fixed by #24

Comments

@shadowhand
Copy link
Contributor

We have been getting a fair number of the following errors:

Unhandled AsyncAws\Core\Exception\Http\NetworkException (0) error: Could not contact remote server.

It seems like these NetworkException errors should be caught inside of getRawItem and throw a CacheItemNotFoundException, as in:

try {
    return $item->getItem();
} catch (NetworkException) {
    throw new CacheItemNotFoundException();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant