Fix zoom bugs #2988
Merged
Fix zoom bugs #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbarnwal
added
the
blocker
AdityaHegde
reviewed
Aug 29, 2023
| $dashboardStore?.selectedScrubRange?.start, | ||
| $dashboardStore?.selectedScrubRange?.end | ||
| ); | ||
| metricsExplorerStore.setSelectedTimeRange(metricViewName, { |
There was a problem hiding this comment.
Why not merge these actions instead of using setTimeout?
There was a problem hiding this comment.
I tried merging it into a single dashboard reducer call but the two values (timeRange and scrubRange) are serialized independently on the protos. Successive calls without any delay leads to race condition.
AdityaHegde
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary
Issue addressed:
Zwas usedDetails:
<svelte:window>to a component single component so to avoid multiple dispatches/state changes for the same keybinding.Steps to Verify
Play around with zoom on a dashboard with 5 or more charts.