Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove repeated time zone calls #3055

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Remove repeated time zone calls #3055

merged 1 commit into from
Sep 11, 2023

Conversation

djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Sep 10, 2023 •
edited
Loading

Checklist

  • Manual verification
  • Unit test coverage
  • E2E test coverage
  • Needs manual QA?

Summary

Issue addressed:

Scrub was not working on some of the charts. On further inspection saw that setTimeZone was being called every time the app re-rendered and dispatched a call to set the scrub as undefined.

Details:

For dashboards without any time zone we were making repeated state calls. This PR fixes that issue.

Steps to Verify

  1. Scrub on a dashboard without any timezone keys defined
  2. The scrub should work

@AdityaHegde AdityaHegde merged commit 1bcab84 into main Sep 11, 2023
2 checks passed
@AdityaHegde AdityaHegde deleted the fix/repeated-zone-calls branch September 11, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHegde AdityaHegde AdityaHegde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djbarnwal @AdityaHegde