-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prettierignore -- ignore .gitkeep and yaml #3214
Conversation
@ericpgreen2 quick one here for you |
What's the motivation for this? Isn't it helpful to have Prettier check YAML? ChatGPT thinks we shouldn't make this change 😅 |
Motivation is to reduce noise on prettier check. For example, i get the following
ChatGPT is hallucinating about .gitkeep files at least -- prettier does not support those. But yeah we can keep the yaml checks if you want -- I updated this PR to ignore the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this works. I wonder though – instead of ignoring dev-project
, should we be better formatting the YAML files we create to adhere to prettier
?
merged this for now, but happy to revisit this if you wish -- I'm really not attached to this solution if you want to try something else :-) My understanding was that this particular folder is really intended for user scratchpad, and not something that we should necessarily be putting a lot of effort into formatting. That's not right, we can add automatic formatting for the yaml files, But we should have a discussion about whether we want to force prettier formatting on all users including those who may not know what it's doing or may have their own particular desires about how they want their files to be formatted. I wast mostly thinking that this is probably the fastest path to reducing the noise in the pretty raw output for the time being. |
couple tiny updates to prettierignore