Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating available_time_ranges in UI #3531

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Nov 21, 2023

Checklist

  • Manual verification
  • Unit test coverage
  • E2E test coverage
  • Needs manual QA?

Summary

Issue addressed:

We added backend support for available_time_ranges but no UI support.

Details:

  1. Refactor TimeRangeSelector to use a new selector that provides the list of available time ranges from available_time_ranges config.
  2. Refactor TimeComparisonSelector to use a new selector that provides the list of available comparison options from available_time_ranges or the default.

Steps to Verify

  1. Create a dashboard with timestamp.
  2. Add this setting to start testing,
available_time_ranges:
  - PT6H
  - range: P5D
    comparison_offsets:
      - rill-PP
      - rill-PW
  - P4W
  - rill-WTD
  - rill-MTD

@AdityaHegde AdityaHegde self-assigned this Nov 22, 2023
@AdityaHegde AdityaHegde marked this pull request as ready for review November 22, 2023 07:19
Copy link
Member

@djbarnwal djbarnwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX Review -
Comparing Last 5 Days vs Last 7 Days

image
image

I would expect these charts to look similar

@AdityaHegde
Copy link
Collaborator Author

Looks like the issue was from an unrelated issue that was fixed in main. @djbarnwal I have merged main now. That issue should be there anymore.

Copy link
Member

@djbarnwal djbarnwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good, synced up with Aditya offline regarding UX bug in the chart adjusted time.

@djbarnwal djbarnwal merged commit f9d9a38 into main Nov 29, 2023
2 checks passed
@djbarnwal djbarnwal deleted the adityahegde/available_time_ranges branch November 29, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants