-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud UI: add resource-level status to the project status page #3781
Conversation
/{org}/{project}/-/status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments but looks good otherwise.
import { createRuntimeServiceGetResource } from "@rilldata/web-common/runtime-client"; | ||
import { runtime } from "@rilldata/web-common/runtime-client/runtime-store"; | ||
|
||
$: parserErrors = createRuntimeServiceGetResource( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent here is to only show parse errors and not reconcile errors right? Because in my project this shows no errors but there are a couple resources with reconcile errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct – those (resource-specific) reconcile errors should be shown in the table above in the "Error" column. Do you see them there?
This PR enhances the Cloud UI project status page with resource-level status. Previously, we synthesized the resource-level status and displayed one project-wide status. This hid rich reconciliation data from the user and led to confusion. With this PR, we split out and display individual resource status (including execution state, errors, last refresh time, and next refresh time).
This PR builds off of #3786, which adds ShadCN's Data Table component set.
Here's an example of what the new page looks like: