Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud UI: add resource-level status to the project status page #3781

Merged
merged 31 commits into from
Jan 9, 2024

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jan 5, 2024

This PR enhances the Cloud UI project status page with resource-level status. Previously, we synthesized the resource-level status and displayed one project-wide status. This hid rich reconciliation data from the user and led to confusion. With this PR, we split out and display individual resource status (including execution state, errors, last refresh time, and next refresh time).

This PR builds off of #3786, which adds ShadCN's Data Table component set.

Here's an example of what the new page looks like:
image

@ericpgreen2 ericpgreen2 added the Team:Applications Applications Working Group label Jan 5, 2024
@ericpgreen2 ericpgreen2 self-assigned this Jan 5, 2024
@ericpgreen2 ericpgreen2 changed the title Cloud UI: add resource-level status to /{org}/{project}/-/status Cloud UI: add resource-level status to the project status page Jan 6, 2024
@ericpgreen2 ericpgreen2 marked this pull request as ready for review January 6, 2024 00:33
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments but looks good otherwise.

import { createRuntimeServiceGetResource } from "@rilldata/web-common/runtime-client";
import { runtime } from "@rilldata/web-common/runtime-client/runtime-store";

$: parserErrors = createRuntimeServiceGetResource(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent here is to only show parse errors and not reconcile errors right? Because in my project this shows no errors but there are a couple resources with reconcile errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct – those (resource-specific) reconcile errors should be shown in the table above in the "Error" column. Do you see them there?

web-common/src/components/tag/Tag.svelte Show resolved Hide resolved
@ericpgreen2 ericpgreen2 merged commit f35caaa into main Jan 9, 2024
4 checks passed
@ericpgreen2 ericpgreen2 deleted the resource-level-status branch January 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Applications Applications Working Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants