Druid Explore Exactify mode #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2024 14:13
nishantmonu51
previously approved these changes
Mar 21, 2024
added 2 commits
March 22, 2024 13:04
Comment on lines
+117
to
+122
| // comparison toplist | ||
| if !isTimeRangeNil(q.ComparisonTimeRange) { | ||
| // execute toplist for base and get dim list | ||
| // create and add filter and execute comprison toplist | ||
| // remove strict limits in comp toplist sql | ||
| if drivers.DialectDruid != olap.Dialect() || q.Exact { |
There was a problem hiding this comment.
I'm worried about how inlined/nested/scattered this fix is since the comparison logic is already tricky to follow. I'm wondering if it could we moved into a separate branch of logic without altering the existing implementation too much? For example, something like this on line 117:
if olap.Dialect() == drivers.DialectDruid && !q.Exact {
return q.executeDruidApproximate(ctx, olap, mv, priority, security)
}
|
Benchmarks |
begelundmuller
approved these changes
Mar 25, 2024
nishantmonu51
pushed a commit
that referenced
this pull request
Mar 25, 2024
* Druid Exactify * Druid Exactify * Druid Exactify * Druid Exactify * Druid Exactify --------- Co-authored-by: Egor Ryashin <egor.ryashin@rilldata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.