Improve reconcilation performance for external dashboards #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves reconcilation time on druid based dashboard having 45 dims and 30 measures from 50 sec to 4 sec.
|
@nishantmonu51 main change is its doing all dims and measures in one go and if there are any errors then go one by one on them to find actual failing one ? |
pjain1
approved these changes
Mar 31, 2024
|
Yes, its trying to improve reconcilation time by doing the check in one shot rather than one by one. Prepares one query instead of 70. |
nishantmonu51
added a commit
that referenced
this pull request
Mar 31, 2024
* Improve validation for external dashboards Improves reconcilation time on druid based dashboard having 45 dims and 30 measures from 50 sec to 4 sec. * Fix test errors * Fix linting * fix lint * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves reconcilation time on druid based dashboard having 45 dims and 30 measures from 50 sec to 4 sec.