Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better semantic version for main builds #4512

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Better semantic version for main builds #4512

merged 1 commit into from
Apr 9, 2024

Conversation

himadrisingh
Copy link
Contributor

Please go the the Preview tab and select the appropriate sub-template:

@himadrisingh himadrisingh self-assigned this Apr 4, 2024
Copy link
Collaborator

@nishantmonu51 nishantmonu51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Kavinjsir Kavinjsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Just one question: What is the use case for us to add the SHA as a suffix after a semver?

@himadrisingh himadrisingh merged commit beaad16 into main Apr 9, 2024
3 checks passed
@himadrisingh himadrisingh deleted the sem-version branch April 9, 2024 11:49
himadrisingh added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants