refactor: update scaling strategies #5333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavinjsir
requested review from
himadrisingh,
begelundmuller,
nishantmonu51 and
kaspersjo
Kavinjsir
force-pushed
the
tony-patch-slot-scaler
branch
2 times, most recently
from
10b2cdc
to
f2d9267
Compare
Kavinjsir
force-pushed
the
tony-patch-slot-scaler
branch
from
f2d9267
to
a51c2ac
Compare
himadrisingh
approved these changes
Jul 24, 2024
Kavinjsir
commented
Jul 24, 2024
| } | ||
|
|
||
| if reason == scaledown { | ||
| w.logger.Info(logMessage, logFields...) |
There was a problem hiding this comment.
@nishantmonu51 for "not scaling down", the code here is designed to leave a message so that we can later create a datadog monitor to capture the log pattern with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the slot autoscaler:
Motivation
Resolve: https://github.com/rilldata/rill-private-issues/issues/475