Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent caret_pos #860

Closed
wants to merge 1 commit into from
Closed

Consistent caret_pos #860

wants to merge 1 commit into from

Conversation

groverlynn
Copy link
Contributor

Make the variable caret_pos consistent when soft cursor is present (i.e. always equals to the location right BEFORE the soft cursor). Currently, when the caret is at the start/end of set_range, caret_pos equals to the location right after/before the soft cursor, respectively.

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Make the variable `caret_pos` consistent when soft cursor is present (i.e. always equals to the location right BEFORE the soft cursor). Currently, when the caret is at the start/end of set_range, caret_pos equals to the location right after/before the soft cursor, respectively.
@lotem lotem closed this in f5df6cd Apr 27, 2024
@lotem
Copy link
Member

lotem commented Apr 27, 2024

the real problem is how sel_start is updated. fixed in f5df6cd

@groverlynn groverlynn deleted the patch-1 branch April 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants