wrap-stacktrace is awkward to call conditionally

[technomancy]

Typically you only want wrap-stacktrace to take effect in a development setting. Doing this with environ looks something like this:

(jetty/run-jetty (-> #'app
                     ((if (env/env :dev)
                        trace/wrap-stacktrace
                        identity))
                     [...])
                 {:port port :join? false})

If wrap-stacktrace took a second argument to turn it into a no-op, it would be easier to use in the context of ->.

(jetty/run-jetty (-> #'app
                     (trace/wrap-stacktrace (env/env :production))
                     [...])
                 {:port port :join? false})

What do you think?

[seancorfield]

To me that reads as if wrap-stacktrace should apply only in a production setting. Wouldn't the more natural usage be:

(trace/wrap-stacktrace (env/env :dev))

or at least:

(trace/wrap-stacktrace (not (env/env :production)))

[technomancy]

Good call; the option should probably be stated in the positive rather than the negative.

[weavejester]

Sorry for taking a while to notice this. I'm not getting notifications for the ring-clojure organization anymore.

[weavejester]

I think that this might not be the best idea...

The wrap-stacktrace middleware isn't the only middleware a developer might want to use only in development, and the idea of encasing an if-statement in every middleware function that might not be used in a production environment strikes me as redundant.

Instead, perhaps just factoring development middleware into a separate function could be a solution:

(defn wrap-dev-middleware [handler]
  (if (= (env :ring-env) "production")
    handler
    (-> handler
        wrap-stacktrace
        wrap-reload
        wrap-whatever-else)))

[technomancy]

Yeah, on further consideration this is probably too specific and not the right place for it.