Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .json() methods #23

Closed
wants to merge 2 commits into from
Closed

Conversation

Brutalbeard
Copy link
Contributor

Noticed a lot of the methods in the SDK which should be returning a json object, were still returning raw data.

Copied the correct thenable into the appropriate methods.

@Brutalbeard
Copy link
Contributor Author

@kirill-konshin - when you get a minute.

@kirill-konshin
Copy link
Contributor

kirill-konshin commented Dec 10, 2018

wipe-wipe-wipe

There are *Raw method versions, I think we should alter the code to use raw then .json() instead of current duplication.

Json can be added only in case the returned response is always JSON, not multipart, for example.

There's an if for that in code generator: {% if op.responseType != 'any' and op.responseType != 'void' %}. Have you used code generator to do the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants