Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl: ISO 3166-2 subdivision codes fixed #225

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

DSpeichert
Copy link
Contributor

@codeclimate
Copy link

codeclimate bot commented May 8, 2022

Code Climate has analyzed commit 7c007ac and detected 0 issues on this pull request.

View more on Code Climate.

@Omranic Omranic changed the base branch from master to develop May 9, 2022 03:07
@Omranic
Copy link
Member

Omranic commented May 9, 2022

This seems to be a wrong misconfigured PR, kindly double check the modifications, and submit again. Thanks!

@Omranic Omranic closed this May 9, 2022
@DSpeichert
Copy link
Contributor Author

@Omranic Could you please explain what appears to be wrong with the changes proposed?

I think this is the only place where those erroneously defined subdivision codes need to be corrected, is it not?

@Omranic
Copy link
Member

Omranic commented May 15, 2022

Try to compare both files side by side to see what I mean 🙂 Feel free to fix and update again, I'll be happy to re-consider.
Screen Shot 2022-05-15 at 1 23 52 PM copy

@DSpeichert
Copy link
Contributor Author

On your screenshot, it looks like you're comparing resources/data/pl.json with resources/divisions/pl.json.

If you look at Files changed tab, you can see only the IDs of the divisions were changed in this PR, nothing to do with the resources/data/pl.json file.

@Omranic
Copy link
Member

Omranic commented Dec 7, 2022

@DSpeichert Thank you for pointing this out, my bad, wrong file comparison!

Now I see what you mean, now I seem to understand this update. Let me fix that.

@Omranic Omranic reopened this Dec 7, 2022
@Omranic Omranic merged commit 80614d9 into rinvex:develop Dec 7, 2022
@DSpeichert DSpeichert deleted the patch-1 branch December 13, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants