Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support additional mapping method parameters #1400

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jul 16, 2024

Supports additional mapping parameters to be added to user defined mapping methods. These additional parameters are considered as source members and matched against target members in a case-insensitive manner. Additional mapping method parameters are not passed to nested mappings and a mapping method with additional parameters cannot be the default mapping for a given type pair.

Closes #103

@latonz latonz added the enhancement New feature or request label Jul 16, 2024
@latonz latonz self-assigned this Jul 16, 2024
@latonz latonz force-pushed the feat-additional-parameters branch 3 times, most recently from e1bc241 to 08fc87d Compare July 17, 2024 03:16
@latonz latonz marked this pull request as ready for review July 17, 2024 03:21
@latonz latonz force-pushed the feat-additional-parameters branch 3 times, most recently from e4a8590 to fa66eab Compare July 18, 2024 01:45
@latonz latonz force-pushed the feat-additional-parameters branch 3 times, most recently from 8a88574 to 2adf089 Compare July 24, 2024 02:21
@latonz latonz requested a review from CommonGuy July 24, 2024 02:22
@latonz latonz enabled auto-merge (squash) July 24, 2024 02:22
@latonz latonz force-pushed the feat-additional-parameters branch from 2adf089 to 9fb2f41 Compare July 24, 2024 15:10
Co-authored-by: Qin Guan <qinguan20040914@gmail.com>
@latonz latonz force-pushed the feat-additional-parameters branch from 9fb2f41 to e4f7e9c Compare July 24, 2024 15:14
@latonz latonz requested a review from CommonGuy July 24, 2024 15:15
@latonz latonz merged commit 78e2e16 into riok:main Jul 26, 2024
17 checks passed
@latonz latonz deleted the feat-additional-parameters branch July 28, 2024 19:08
@aradalvand
Copy link
Contributor

aradalvand commented Aug 4, 2024

Hey guys, thanks a lot for your efforts! I've been waiting for this feature for a long time, when will the v4.0.0-next.2 release be published, do you think?

@latonz
Copy link
Contributor Author

latonz commented Aug 4, 2024

@aradalvand there are quite some open PRs, we will wait until most of them are merged. Due to the holiday season in europe this can take a bit more time than usual…

@koniecdev
Copy link

Finally I can use Mapperly as my default go-to mapper in my projects, thanks for that upgrade, works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply additional parameters to the mapping method
5 participants