-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1470 enum naming strategy #1486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this contribution, I added my feedback 😊
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
...k.Mapperly.IntegrationTests/_snapshots/MapperTest.SnapshotGeneratedSource_NET8_0.verified.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast updates 😊 I added my feedback. I think a lot will change again with the implementation of #1486 (comment).
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/Mappings/Enums/EnumFallbackToStringMapping.cs
Outdated
Show resolved
Hide resolved
711c763
to
89e560e
Compare
I still couldn't get the documentation fix to run on my Mac. I tried yarn and npm, but they both are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates and your patience 😊
I'll fix the linter issues as soon as everything else is ready for merging 👍
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/StringToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/StringToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/EnumToStringMappingBuilder.cs
Outdated
Show resolved
Hide resolved
src/Riok.Mapperly/Descriptors/MappingBuilders/StringToEnumMappingBuilder.cs
Outdated
Show resolved
Hide resolved
89e560e
to
db51297
Compare
Enum from/to string naming strategies
Description
Added support for enum from/to string naming strategies (PascalCase, snake_case, kebab-case)
Fixes #1470
Checklist