fix: clone array when deepcloning is enabled and target is an IEnumerble #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able If the source type is an array, the target type is an IEnumerable, the source should be cloned instead of casted This also extracts deep cloning enumerable tests into a separate test class.
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 92.08% 92.15% +0.07%
==========================================
Files 135 135
Lines 4282 4282
Branches 591 590 -1
==========================================
+ Hits 3943 3946 +3
+ Misses 225 224 -1
+ Partials 114 112 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ni507
approved these changes
May 16, 2023
|
🎉 This PR is included in version 2.9.0-next.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source type is an array, the target type is an IEnumerable, the source should be cloned instead of casted
This also extracts deep cloning enumerable tests into a separate test class.
Fixes an issue similar to #426