Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit enum mappings for byValue enum mappings #489

Merged
merged 1 commit into from
Jun 12, 2023
Merged

feat: explicit enum mappings for byValue enum mappings #489

merged 1 commit into from
Jun 12, 2023

Conversation

latonz
Copy link
Contributor

@latonz latonz commented Jun 9, 2023

explicit enum mappings for byValue enum mappings

Fixes #482

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz latonz requested review from ni507 and removed request for ni507 June 9, 2023 13:48
@latonz latonz self-assigned this Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #489 (9e65cbc) into main (b17f666) will increase coverage by 0.36%.
The diff coverage is 94.65%.

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   92.08%   92.45%   +0.36%     
==========================================
  Files         135      141       +6     
  Lines        4282     4491     +209     
  Branches      591      573      -18     
==========================================
+ Hits         3943     4152     +209     
- Misses        225      226       +1     
+ Partials      114      113       -1     
Impacted Files Coverage Δ
...iok.Mapperly.Abstractions/MapEnumValueAttribute.cs 0.00% <0.00%> (ø)
...scriptors/InlineExpressionMappingBuilderContext.cs 95.12% <ø> (ø)
...appingBodyBuilders/UserMethodMappingBodyBuilder.cs 90.47% <ø> (ø)
...Riok.Mapperly/Descriptors/MappingBuilderContext.cs 98.14% <ø> (ø)
...erly/Descriptors/MappingBuilders/MappingBuilder.cs 100.00% <ø> (ø)
src/Riok.Mapperly/Descriptors/MappingCollection.cs 100.00% <ø> (ø)
...iok.Mapperly/Descriptors/Mappings/MethodMapping.cs 95.00% <ø> (ø)
...Mappings/UserDefinedExistingTargetMethodMapping.cs 87.17% <ø> (ø)
...serMappings/UserDefinedNewInstanceMethodMapping.cs 100.00% <ø> (ø)
...pings/UserMappings/UserImplementedMethodMapping.cs 90.90% <ø> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@latonz latonz marked this pull request as ready for review June 9, 2023 14:29
@latonz latonz requested review from CommonGuy and ni507 June 9, 2023 14:29
@latonz latonz enabled auto-merge (squash) June 9, 2023 14:29
@latonz latonz requested a review from ni507 June 12, 2023 07:28
ni507
ni507 previously approved these changes Jun 12, 2023
@latonz latonz merged commit 029dae2 into riok:main Jun 12, 2023
@latonz latonz deleted the 482-explicit-by-value-enum-mappings branch June 12, 2023 07:54
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@latonz latonz added this to the v2.9.0 milestone Jun 14, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit enum value mapping for ByValue enum mappings
2 participants