Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nullable<T>.Value is no longer treated as a member #575

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

TimothyMakkison
Copy link
Collaborator

@TimothyMakkison TimothyMakkison commented Jul 18, 2023

Nullable<T>.Value is no longer treated as a member

Description

Added check to SymbolAccessor for nullable value types. This way Nullable<T>.Value will not be treated as a member resulting in invalid auto resolved flattenings

Fixes #572 & #571

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • Unit tests are added/updated

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #575 (fd13d12) into main (3244a52) will decrease coverage by 0.01%.
The diff coverage is 94.91%.

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   91.09%   91.08%   -0.01%     
==========================================
  Files         167      167              
  Lines        5669     5656      -13     
  Branches      716      716              
==========================================
- Hits         5164     5152      -12     
+ Misses        352      351       -1     
  Partials      153      153              
Impacted Files Coverage Δ
src/Riok.Mapperly/Descriptors/DescriptorBuilder.cs 100.00% <ø> (ø)
src/Riok.Mapperly/Descriptors/WellKnownTypes.cs 92.00% <0.00%> (ø)
...lders/NewInstanceObjectMemberMappingBodyBuilder.cs 79.41% <75.00%> (-0.59%) ⬇️
src/Riok.Mapperly/ImmutableEquatableArray.cs 59.37% <80.00%> (-1.24%) ⬇️
...pingBodyBuilders/ObjectMemberMappingBodyBuilder.cs 100.00% <100.00%> (ø)
src/Riok.Mapperly/Descriptors/SymbolAccessor.cs 99.09% <100.00%> (+1.73%) ⬆️
.../Riok.Mapperly/Helpers/NullableSymbolExtensions.cs 94.73% <100.00%> (ø)
src/Riok.Mapperly/Symbols/MemberPath.cs 83.13% <100.00%> (-5.40%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, only little formatting issues...

@latonz latonz merged commit b238481 into riok:main Jul 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.9.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flattening nested nullable value types does not work
2 participants