can't build

[Ivshti]

can't seem to build longs, getting this:

Ivo-MacBook-Pro:longs ivogeorgiev$ make 
cc -W -Wall -O2 -Wno-unused-parameter -g -D NOPE_THREADS= -pthread     -c -o waferapi.o waferapi.c
waferapi.c:268:14: error: use of undeclared identifier 'BUFFLEN'
    char buf[BUFFLEN];
             ^
waferapi.c:270:45: error: use of undeclared identifier 'BUFFLEN'
    ssize_t bytes_read = read(read_fd, buf, BUFFLEN);
                                            ^
waferapi.c:271:45: error: use of undeclared identifier 'cbuf'; did you mean 'buf'?
    ssize_t bytes_written = write(write_fd, cbuf, bytes_read);
                                            ^~~~

I grepped everything for BUFFLEN but there's no such thing. Furthermore I googled the errors, again nothing

[rrezel]

Are you trying to build this on OSX?

[Ivshti]

yes, is this relevant? sqlite3 is certainly OK on OSX, not sure about wafer

[Ivshti]

do you know where BUFFLEN comes from?

[rrezel]

yes, is this relevant?
Yes:
#ifndef __linux__

That part of the code never got tested. It's a bug. We're sorry. We'll fix it.

[rrezel]

This should be fixed now. Can you please verify?

[Ivshti]

hm..seems to be the same after I pulled

7 warnings generated.
cc -W -Wall -O2 -Wno-unused-parameter -g      -pthread -c -o waferapi.o waferapi.c
waferapi.c:268:14: error: use of undeclared identifier 'BUFFLEN'
    char buf[BUFFLEN];
             ^
waferapi.c:270:45: error: use of undeclared identifier 'BUFFLEN'
    ssize_t bytes_read = read(read_fd, buf, BUFFLEN);
                                            ^
waferapi.c:271:45: error: use of undeclared identifier 'cbuf'; did you mean 'buf'?
    ssize_t bytes_written = write(write_fd, cbuf, bytes_read);
                                            ^~~~
                                            buf
waferapi.c:268:10: note: 'buf' declared here
    char buf[BUFFLEN];
         ^

I also tried deleting all .o files and build artifacts

[rrezel]

I think I didn't push the changes. BUFFLEN shouldn't be there at all. Would you mind trying again? I'm really sorry about this.

[Ivshti]

Thanks a lot of the help

Now it's that:

waferapi.c:271:45: error: use of undeclared identifier 'cbuf'; did you mean 'buf'?
    ssize_t bytes_written = write(write_fd, cbuf, bytes_read);
                                            ^~~~
                                            buf
waferapi.c:268:10: note: 'buf' declared here
    char buf[MAX_BUFFER_SIZE];
         ^

Should I replace buf with cbuf? Doesn't look that way

[Ivshti]

Replaced cbuf with buf. Works now

[rrezel]

Thanks for the PR.