Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency list not scrolling #137

Closed
jackrua opened this issue Jan 23, 2024 · 1 comment
Closed

Currency list not scrolling #137

jackrua opened this issue Jan 23, 2024 · 1 comment
Assignees
@jackrua
Labels
bug Something isn't working

Comments

@jackrua
Copy link
Contributor

jackrua commented Jan 23, 2024

In General Settings/Currency, the Select a currency menu doesn't scroll, hence blocking the user from selecting different currencies.

p2

This is an easy fix, just change physics to BouncingScrollPhysics(). If it's ok for you, I can open the PR and take care of it (moreover I can change the name of the function that is misspelled: sellectCurrency()).
@theperu
Copy link
Collaborator

theperu commented Jan 23, 2024

Hi! Thanks for bringing this up! You're more than welcome to come and help so if you want you can open a PR 👍🏻

@theperu theperu added the bug Something isn't working label Jan 23, 2024
@jackrua jackrua mentioned this issue Jan 23, 2024
Merged
@theperu theperu closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackrua jackrua

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theperu @jackrua