Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

ability to diable alias() for wildcard sources #26

Closed

Conversation

asher
Copy link

@asher asher commented Feb 13, 2012

I implemented this after needing to include targets such as highestMax(..count, 10) where the sources ultimately graphed are unknown.

Adding alias=none to such a graph disables the outer alias call and enables the use of substr() as requested here ripienaar/graphite-graph-dsl#7.

@ripienaar
Copy link
Owner

nice would you mind changing:

if target[:alias] == "none"

to

if target[:alias].to_s == "none"

that way people can use both symbols and strings in the dsl which might be more useful.

Eitherway, I'm going to ened to get this pull request done against https://github.com/ripienaar/graphite-graph-dsl which is where the DSL is maintain - removing it from here soon, sorry for the hassle

@ripienaar ripienaar closed this Feb 13, 2012
@asher
Copy link
Author

asher commented Feb 13, 2012

No worries, thanks for the feedback. I'll send a cleaned up pull request
to the dsl project.

On Mon, Feb 13, 2012 at 1:51 PM, R.I.Pienaar <
reply@reply.github.com

wrote:

nice would you mind changing:

if target[:alias] == "none"

to

if target[:alias].to_s == "none"

that way people can use both symbols and strings in the dsl which might be
more useful.

Eitherway, I'm going to ened to get this pull request done against
https://github.com/ripienaar/graphite-graph-dsl which is where the DSL is
maintain - removing it from here soon, sorry for the hassle


Reply to this email directly or view it on GitHub:
#26 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants