Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to automatically updated links to yomichan dictionaries in the README #196

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

precondition
Copy link
Contributor

The jmdict-yomitan repo of the moe way (https://github.com/themoeway/jmdict-yomitan) automatically produces up-to-date Yomichan/Yomitan versions of JMDict, JMnedict, and KANJIdic with GitHub actions.

The newer versions provide corrections and ameliorations over the old versions archived in FooSoft's repos. Though, an argument could be made that this is naturally less “stable“ and could break or even be the victim of a supply chain attack.

@ripose-jp
Copy link
Owner

Considering toasted-nutbread is involved with Yomitan, I think the project will have plenty of longevity and don't mind changing the links in the README.

Please fix you commit message to follow the guidelines though.

The jmdict-yomitan repo of the moe way
(https://github.com/themoeway/jmdict-yomitan) automatically produces
up-to-date Yomichan/Yomitan versions of JMDict, JMnedict, and KANJIdic
with GitHub actions.
The newer versions provide corrections and ameliorations over the old
versions archived in FooSoft's repos.
@precondition
Copy link
Contributor Author

Changed the commit message

@ripose-jp ripose-jp merged commit c50b7bf into ripose-jp:master Feb 1, 2024
2 of 3 checks passed
@precondition precondition deleted the link_to_update_dicts branch February 1, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants