-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with ? for parameters. #10
Comments
Sounds legit. |
Hm, I would fix it if I would have knowledge in Java. If I'm making a fast look I would assume that app/controllers/Application.java is the server software that gets the request, fetches the website and sends it back to the user. I can't even determine the constructor in this class as I would expect it to be a method with the same name as the class. Well, probably I should simply not try this without a good amount of knowledge in Java. But unfortunately many sites are working with parameters and thus they are currently not working. Lets just hope somebody fixes this issue in the near future. |
+1 On Sun, Oct 5, 2014 at 10:54 AM, Sworddragon notifications@github.com
Ron Gross |
See #12 |
Any idea when can this be fixed? My knowledge of Java is near zero so unfortunately I can’t create any patchs :( |
I'll try to find someone to maintain the project. |
@niksy is the commit running on the production server or not? |
I got around this like so:
Notice the forward slash before the query, you have to escape it first. |
This problem still exists. :( |
My attempt at fixing this is in pull request 22. |
Merged fix & deployed to Heroku. |
The URL scheme forces you to use ampersands after the first ? for parameters. This means you can't currently use Whatever Origin to get a website which uses parameters as you are forced to start the parameters in the requested website's URL with an ampersand which doesn't work, as a question mark is used at the beginning.
The text was updated successfully, but these errors were encountered: