Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with ? for parameters. #10

Closed
will4457 opened this issue Sep 7, 2014 · 13 comments
Closed

Doesn't work with ? for parameters. #10

will4457 opened this issue Sep 7, 2014 · 13 comments

Comments

@will4457
Copy link

will4457 commented Sep 7, 2014

The URL scheme forces you to use ampersands after the first ? for parameters. This means you can't currently use Whatever Origin to get a website which uses parameters as you are forced to start the parameters in the requested website's URL with an ampersand which doesn't work, as a question mark is used at the beginning.

@ripper234
Copy link
Owner

Sounds legit.
Pull requests welcome, FYI the project isn't actively maintained right now.

@Sworddragon
Copy link

Pull requests welcome

Hm, I would fix it if I would have knowledge in Java. If I'm making a fast look I would assume that app/controllers/Application.java is the server software that gets the request, fetches the website and sends it back to the user. I can't even determine the constructor in this class as I would expect it to be a method with the same name as the class. Well, probably I should simply not try this without a good amount of knowledge in Java.

But unfortunately many sites are working with parameters and thus they are currently not working. Lets just hope somebody fixes this issue in the near future.

@ripper234
Copy link
Owner

+1

On Sun, Oct 5, 2014 at 10:54 AM, Sworddragon notifications@github.com
wrote:

Pull requests welcome

Hm, I would fix it if I would have knowledge in Java. If I'm making a fast
look I would assume that app/controllers/Application.java is the server
software that gets the request, fetches the website and sends it back to
the user. I can't even determine the contructor in this class as I would
expect it to be a method with the same name as the class. Well, probably I
should simply not try this without a good amount of knowledge in Java.

But unfortunately many sites are working with parameters and thus they are
currently not working. Lets just hope somebody fixes this issue in the near
future.


Reply to this email directly or view it on GitHub
#10 (comment)
.

Ron Gross
mastercoin.org | ripper234.com | ripper234 on skype (Inbox != Zero
http://ripper234.com/p/how-i-learned-to-let-go-of-inbox-zero/) | PGP
http://pgp.mit.edu/pks/lookup?op=vindex&search=0x7468729E28277264
Schedule my time at meetme.so/RonGross
Chief Ninja Officer http://www.chiefninjaofficer.com/

@ripper234
Copy link
Owner

See #12

@niksy
Copy link

niksy commented Nov 2, 2014

Any idea when can this be fixed? My knowledge of Java is near zero so unfortunately I can’t create any patchs :(

@ripper234
Copy link
Owner

I'll try to find someone to maintain the project.

@niksy
Copy link

niksy commented Nov 2, 2014

I think this is related to #2 which has commit which should probably fix this.

@ripper234
Copy link
Owner

@niksy is the commit running on the production server or not?
I think it is.

@niksy
Copy link

niksy commented Nov 2, 2014

Hm, it seems that fixes in #2 led to reverting that commit (see #1) so I’m not sure this fixes problem entirely.

@mbacklas
Copy link

I got around this like so:

$.getJSON('http://whateverorigin.org/get?url=' + encodeURIComponent('http://www.example.com/xml_to_json.php/?product=') + prod_id +  '&callback=?', function(data){ // stuff here });

Notice the forward slash before the query, you have to escape it first.

@x43x61x69
Copy link

This problem still exists. :(

macdonjo added a commit to macdonjo/Whatever-Origin that referenced this issue Mar 17, 2017
@macdonjo
Copy link
Contributor

My attempt at fixing this is in pull request 22.

ripper234 added a commit that referenced this issue Mar 17, 2017
LGTM, merging.

fixed issue #10
@ripper234
Copy link
Owner

Merged fix & deployed to Heroku.
Plus, updated Heroku stack to cedar-14, it was using an outdated and broken cedar-10 stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants