Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to react@18 #668

Open
ckniffen opened this issue Apr 13, 2023 · 0 comments
Open

Upgrade to react@18 #668

ckniffen opened this issue Apr 13, 2023 · 0 comments

Comments

@ckniffen
Copy link
Collaborator

ckniffen commented Apr 13, 2023 •
edited by mvadari
Loading

Dependencies

Other changes at the same time:
@ckniffen ckniffen mentioned this issue Apr 13, 2023
Merged
7 tasks
@mvadari mvadari mentioned this issue Dec 1, 2023
Merged
1 task
ckniffen added a commit that referenced this issue Jan 5, 2024
@mvadari @ckniffen
refactor: switch to react18-json-view (#890)
cceb18a 
This PR replaces `react-json-view` with `react18-json-view`. This
results in 18 less dependencies and a 2kb smaller gzipped bundle.

There were a few small tweaks to the json view themes to use the closest
color within the sites color palette (previously they were one offs) and
margins/padding.

### Context of Change

`react-json-view` doesn't work with React 18 and is also much bigger
than `react18-json-view`. Related to #668.

mac-s-g/react-json-view#441

Co-authored-by: Caleb Kniffen <ckniffen@ripple.com>
@mvadari mvadari mentioned this issue Apr 18, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ckniffen