Add conditional tracking pixel #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI bundle preview build successful! ✅ |
|
Antora site build successful! ✅ |
eric-schneider
changed the title
mlr
reviewed
May 2, 2024
colegoldsmith
approved these changes
May 2, 2024
|
@eric-schneider To answer your question, yep adding this to the partials will include it on every page as long as the |
|
UI bundle preview build successful! ✅ |
|
Antora site build successful! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: DOC-4013
Resolves: #117
This PR adds a new partial,
tracking-pixel.hbs, that implements a conditional tracking pixel with a variable ID. The tracking pixel code will only get built into pages when thesite.keys.scarf_tracking_pixelkey is defined in the playbook and assigned a value:See related playbook change.
From what I understand, tracking pixels are usually placed right before the closing
</body>tag so that they don’t delay the loading of any visible content. For this reason, I've inserted thetracking-pixelpartial at the bottom ofbody.hbs.@colegoldsmith, this ensures that the pixel will get included on every page, correct?
I've also seen it suggested that it's a good idea to hide the pixel with a CSS style so that the pixel doesn’t interact with other CSS on the page. For this reason, I've added
style="display:noneto the pixel.