add homepage layout and styles #30
Conversation
| } | ||
|
|
||
| /* Hide sidebar, a.anchor */ | ||
| html[data-layout="landing"] .toc.sidebar, | ||
| html[data-layout="landing"] .toc.embedded, | ||
| html[data-layout="landing"] .breadcrumbs, | ||
| html[data-layout="landing"] a.anchor { | ||
| html[data-layout="landing"] a.anchor, | ||
| html[data-layout="full"] .nav-container, |
There was a problem hiding this comment.
We can keep this as is for now since there will be a demo soon, but I'd like to see these elements not rendered with logic in the handlebars templates rather than hidden via CSS. I think having the handlebars templates act as the building blocks and rendering logic is much more organized than hiding elements like this as the css tends to get chaotic after a while and it's hard to understand why certain elements are shown/hidden. It also saves a little time on the client by simply not rendering the elements vs rendering and then hiding.
There was a problem hiding this comment.
Thanks for the feedback! I noticed a few caveats with handlebars template for some js and hide it with css in the meantime. I will resolve and use handlebars templates in the next PR.
Homepage layout
page-layout: full