Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSP-15832: Use home dir for Spark JobServer data and logs #18

Merged
merged 1 commit into from
May 11, 2018

Conversation

jacek-lewandowski
Copy link

No description provided.

@@ -14,12 +14,12 @@ spark {

jobserver {
port = 8090
jar-store-rootdir = /tmp/jobserver/jars
jar-store-rootdir = ${HOME}/.spark-jobserver/jars

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this config has variable expansion? Will Spark Jobserver eventually replace ${HOME} with actual path?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does

@@ -22,13 +22,13 @@ spark {
# }

filedao {
rootdir = /tmp/spark-jobserver/filedao/data
rootdir = ${HOME}/.spark-jobserver/filedao/data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in dse.conf


jobdao = spark.jobserver.io.JobFileDAO

filedao {
rootdir = /tmp/spark-job-server/filedao/data
rootdir = ${HOME}/.spark-jobserver/filedao/data

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will cause "historical data" loss after upgrade. Jars, info about past jobs will be missing after upgrade. Do we want to do it in patch release?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that people can stick to old configuration. I don't know if configuration files are being changed when upgrading patch release at all (my guess would be no).
All in all, this is something we should ask @brianmhess

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, the ticket is about not creating such directories with 777 permissions because they would not pass security audits. So I don't think we have other ways to fix that than notifying users to copy their files to respective home directories.

@jacek-lewandowski jacek-lewandowski merged commit 958a676 into dse May 11, 2018
@jacek-lewandowski jacek-lewandowski deleted the DSP-15832-dse branch May 11, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants